From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: Robert Richter <rric@kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Tejun Heo <tj@kernel.org>,
oprofile-list@lists.sf.net, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] s390/oprofile: Remove deprecated create_workqueue
Date: Wed, 8 Jun 2016 03:29:12 +0530 [thread overview]
Message-ID: <20160607215912.GA19722@Karyakshetra> (raw)
A dedicated workqueue has been used since the workqueue hws_wq with
workitem &cb->worker, is involved in hardware based sampling
on System z processors.
Since, these are long-running work items and aren't involved in memory
reclaim in any way, system_long_wq has been used.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
arch/s390/oprofile/hwsampler.c | 21 +++------------------
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/arch/s390/oprofile/hwsampler.c b/arch/s390/oprofile/hwsampler.c
index ff9b4eb..8b16bb8 100644
--- a/arch/s390/oprofile/hwsampler.c
+++ b/arch/s390/oprofile/hwsampler.c
@@ -42,7 +42,6 @@ static DEFINE_MUTEX(hws_sem_oom);
static unsigned char hws_flush_all;
static unsigned int hws_oom;
static unsigned int hws_alert;
-static struct workqueue_struct *hws_wq;
static unsigned int hws_state;
enum {
@@ -189,8 +188,7 @@ static void hws_ext_handler(struct ext_code ext_code,
inc_irq_stat(IRQEXT_CMS);
atomic_xchg(&cb->ext_params, atomic_read(&cb->ext_params) | param32);
- if (hws_wq)
- queue_work(hws_wq, &cb->worker);
+ queue_work(system_long_wq, &cb->worker);
}
static void worker(struct work_struct *work);
@@ -566,15 +564,12 @@ int hwsampler_deactivate(unsigned int cpu)
} else {
hws_flush_all = 1;
/* Add work to queue to read pending samples.*/
- queue_work_on(cpu, hws_wq, &cb->worker);
+ queue_work_on(cpu, system_long_wq, &cb->worker);
}
}
}
mutex_unlock(&hws_sem);
- if (hws_wq)
- flush_workqueue(hws_wq);
-
return rc;
}
@@ -740,7 +735,7 @@ static void worker_on_finish(unsigned int cpu)
continue;
if (!cb->finish) {
cb->finish = 1;
- queue_work_on(i, hws_wq,
+ queue_work_on(i, system_long_wq,
&cb->worker);
}
}
@@ -997,9 +992,6 @@ int hwsampler_setup(void)
goto setup_exit;
rc = -EINVAL;
- hws_wq = create_workqueue("hwsampler");
- if (!hws_wq)
- goto setup_exit;
register_cpu_notifier(&hws_cpu_notifier);
@@ -1049,9 +1041,6 @@ int hwsampler_shutdown(void)
if (hws_state == HWS_DEALLOCATED || hws_state == HWS_STOPPED) {
mutex_unlock(&hws_sem);
- if (hws_wq)
- flush_workqueue(hws_wq);
-
mutex_lock(&hws_sem);
if (hws_state == HWS_STOPPED) {
@@ -1059,10 +1048,6 @@ int hwsampler_shutdown(void)
hws_alert = 0;
deallocate_sdbt();
}
- if (hws_wq) {
- destroy_workqueue(hws_wq);
- hws_wq = NULL;
- }
unregister_external_irq(EXT_IRQ_MEASURE_ALERT, hws_ext_handler);
hws_state = HWS_INIT;
--
2.1.4
next reply other threads:[~2016-06-07 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 21:59 Bhaktipriya Shridhar [this message]
2016-06-07 23:29 ` [PATCH] s390/oprofile: Remove deprecated create_workqueue kbuild test robot
2016-06-09 9:00 ` Heiko Carstens
2016-06-13 16:29 ` Robert Richter
2016-06-13 20:44 ` William Cohen
2016-06-14 5:36 ` Heiko Carstens
2016-06-14 13:28 ` Robert Richter
2016-06-14 15:56 ` Heiko Carstens
2016-06-17 9:08 ` Hendrik Brueckner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607215912.GA19722@Karyakshetra \
--to=bhaktipriya96@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).