From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 5 Sep 2016 13:34:36 +0200 From: Hendrik Brueckner Subject: Re: [PATCH] s390/cpum_cf: Use kmalloc_array() in merge_attr() References: <97bb5de4-f9c1-1e2c-cf39-3ecfee114d52@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97bb5de4-f9c1-1e2c-cf39-3ecfee114d52@users.sourceforge.net> Message-Id: <20160905113436.GA4502@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Heiko Carstens , Hendrik =?iso-8859-1?Q?Br=FCckner?= , Martin Schwidefsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini List-ID: On Sat, Sep 03, 2016 at 03:27:42PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 3 Sep 2016 15:17:45 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus reuse the corresponding function "kmalloc_array". > > * Replace the specification of a data type by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > arch/s390/kernel/perf_cpum_cf_events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kernel/perf_cpum_cf_events.c b/arch/s390/kernel/perf_cpum_cf_events.c > index 4554a4b..0d6340b 100644 > --- a/arch/s390/kernel/perf_cpum_cf_events.c > +++ b/arch/s390/kernel/perf_cpum_cf_events.c > @@ -274,7 +274,7 @@ static __init struct attribute **merge_attr(struct attribute **a, > j++; > j++; > > - new = kmalloc(sizeof(struct attribute *) * j, GFP_KERNEL); > + new = kmalloc_array(j, sizeof(*new), GFP_KERNEL); > if (!new) > return NULL; > j = 0; > -- Looks good to me. Thanks. Acked-by: Hendrik Brueckner