From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 30 Oct 2016 14:43:08 +0100 From: Martin Schwidefsky Subject: Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular In-Reply-To: <20161029203843.515-4-paul.gortmaker@windriver.com> References: <20161029203843.515-1-paul.gortmaker@windriver.com> <20161029203843.515-4-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161030144308.03a804de@mschwide> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Heiko Carstens , Michael Holzheu , linux-s390@vger.kernel.org List-ID: On Sat, 29 Oct 2016 16:38:43 -0400 Paul Gortmaker wrote: > The Makefile currently controlling compilation of this code is obj-y, > meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular usage, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_misc_device translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Paul Gortmaker > Cc: Michael Holzheu > Cc: linux-s390@vger.kernel.org > Signed-off-by: Paul Gortmaker That idea behind the patch makes sense to me. But the built robot reports a new warning which should be fixed. If that is done: Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.