From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 7 Nov 2016 10:50:05 +0100 From: Martin Schwidefsky Subject: Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c In-Reply-To: <20161107070322.GA4075@osiris> References: <1478403928-20799-1-git-send-email-yamada.masahiro@socionext.com> <1478403928-20799-2-git-send-email-yamada.masahiro@socionext.com> <20161107070322.GA4075@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20161107105005.3477a324@mschwide> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Heiko Carstens Cc: Masahiro Yamada , linux-s390@vger.kernel.org, Sascha Silbe , Christian Borntraeger , linux-kernel@vger.kernel.org List-ID: On Mon, 7 Nov 2016 08:03:22 +0100 Heiko Carstens wrote: > On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > > We generally expect headers in arch/$(ARCH)/include/asm directory > > are included from kernel sources, but facilities_src.h is not; > > it is included from the arch/s390/tools/gen_facilities.c tool. > > > > There is no reason to expose this header to the public include path. > > Furthermore, facilities_src.h makes sure to be included only from > > gen_facilities.c by the following: > > > > #ifndef S390_GEN_FACILITIES_C > > #error "This file can only be included by gen_facilities.c" > > #endif > > > > This check can be removed by merging the two files. > > > > Signed-off-by: Masahiro Yamada > > --- > > Both patches: > Acked-by: Heiko Carstens > > Martin, can you please pick them up? I will add these two patches to the merge branch for 4.10. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.