Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch

Josh Poimboeuf
2017-01-06T21:04:11Z

On Wed, Jan 04, 2017 at 03:57:09PM +0100, Miroslav Benes wrote:
>
> > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c
> > index bb61c65..0625f38 100644
> > --- a/samples/livepatch/livepatch-sample.c
> > +++ b/samples/livepatch/livepatch-sample.c
> > @@ -89,7 +89,6 @@ static int livepatch_init(void)
> >
> > static void livepatch_exit(void)
> > {
> > - WARN_ON(klp_disable_patch(&patch));
> > WARN_ON(klp_unregister_patch(&patch));
> > }
>
> Btw, we remove the only call to klp_disable_patch() here. Maybe we can
> remove the function completely. It is not needed anywhere.

Maybe so. I haven't heard of anybody needing this interface.

--
Josh