Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

Igor Mammedov
2017-03-13T10:55:54Z

On Thu, 9 Mar 2017 13:54:00 +0100
Michal Hocko <mhocko@kernel.org> wrote:

[...]
> > It's major regression if you remove auto online in kernels that
> > run on top of x86 kvm/vmware hypervisors, making API cleanups
> > while breaking useful functionality doesn't make sense.
> >
> > I would ACK config option removal if auto online keeps working
> > for all x86 hypervisors (hyperv/xen isn't the only who needs it)
> > and keep kernel CLI option to override default.
> >
> > That doesn't mean that others will agree with flipping default,
> > that's why config option has been added.
> >
> > Now to sum up what's been discussed on this thread, there were 2
> > different issues discussed:
> > 1) memory hotplug: remove in kernel auto online for all
> > except of hyperv/xen
> >
> > - suggested RFC is not acceptable from virt point of view
> > as it regresses guests on top of x86 kvm/vmware which
> > both use ACPI based memory hotplug.
> >
> > - udev/userspace solution doesn't work in practice as it's
> > too slow and unreliable when system is under load which
> > is quite common in virt usecase. That's why auto online
> > has been introduced in the first place.
>
> Please try to be more specific why "too slow" is a problem. Also how
> much slower are we talking about?
In virt case on host with lots VMs, userspace handler
processing could be scheduled late enough to trigger a race
between (guest memory going away/OOM handler) and memory
coming online.

>
> > 2) memory unplug: online memory as movable
> >
> > - doesn't work currently with udev rule due to kernel
> > issues https://bugzilla.redhat.com/show_bug.cgi?id=1314306#c7
>
> These should be fixed
>
> > - could be fixed both for in kernel auto online and udev
> > with following patch:
> > https://bugzilla.redhat.com/attachment.cgi?id=1146332
> > but fixing it this way exposes zone disbalance issues,
> > which are not present in current kernel as blocks are
> > onlined in Zone Normal. So this is area to work and
> > improve on.
> >
> > - currently if one wants to use online_movable,
> > one has to either
> > * disable auto online in kernel OR
>
> which might not just work because an unmovable allocation could have
> made the memblock pinned.
With memhp_default_state=offline on kernel CLI there won't be any
unmovable allocation as hotplugged memory won't be onlined and
user can online it manually. So it works for non default usecase
of playing with memory hot-unplug.

> > * remove udev rule that distro ships
> > AND write custom daemon that will be able to online
> > block in right zone/order. So currently whole
> > online_movable thing isn't working by default
> > regardless of who onlines memory.
>
> my epxperience with onlining full nodes as movable shows this works just
> fine (with all the limitations of the movable zones but that is a
> separate thing). I haven't played with configurations where movable
> zones are sharing the node with other zones.
I don't have access to a such baremetal configuration to play
with anymore.

> > I'm in favor of implementing that in kernel as it keeps
> > kernel internals inside kernel and doesn't need
> > kernel API to be involved (memory blocks in sysfs,
> > online_kernel, online_movable)
> > There would be no need in userspace which would have to
> > deal with kernel zoo and maintain that as well.
>
> The kernel is supposed to provide a proper API and that is sysfs
> currently. I am not entirely happy about it either but pulling a lot of
> code into the kernel is not the rigth thing to do. Especially when
> different usecases require different treatment.
If it could be done from kernel side alone, it looks like a better way
to me not to involve userspace at all. And for ACPI based x86/ARM it's
possible to implement without adding a lot of kernel code.
That's one more of a reason to keep CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE
so we could continue on improving kernel only auto-onlining
and fixing current memory hot(un)plug issues without affecting
other platforms/users that are no interested in it.
(PS: I don't care much about sysfs knob for setting auto-onlining,
as kernel CLI override with memhp_default_state seems
sufficient to me)