From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 Mar 2017 07:35:39 +0200 From: Heiko Carstens Subject: Re: [PATCH] mm: fix section name for .data..ro_after_init References: <20170327192213.GA129375@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327192213.GA129375@beast> Message-ID: <20170328053539.GA4902@osiris> Sender: linux-arch-owner@vger.kernel.org Message-ID: <20170328053539.cwI7o_yFWBwxPqqdJQoN4v6d7SnYQuNzFRWIflMW6uo@z> List-Archive: List-Post: To: Kees Cook Cc: Andrew Morton , Martin Schwidefsky , Arnd Bergmann , Catalin Marinas , Chris Metcalf , Jakub Kicinski , linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Eddie Kovsky , linux-kernel@vger.kernel.org List-ID: On Mon, Mar 27, 2017 at 12:22:13PM -0700, Kees Cook wrote: > A section name for .data..ro_after_init was added by both: > > commit d07a980c1b8d ("s390: add proper __ro_after_init support") > > and > > commit d7c19b066dcf ("mm: kmemleak: scan .data.ro_after_init") > > The latter adds incorrect wrapping around the existing s390 section, > and came later. I'd prefer the s390 naming, so this moves the > s390-specific name up to the asm-generic/sections.h and renames the > section as used by kmemleak (and in the future, kernel/extable.c). > > Cc: Jakub Kicinski > Cc: Heiko Carstens > Cc: Eddie Kovsky > Signed-off-by: Kees Cook > --- > arch/s390/include/asm/sections.h | 1 - > arch/s390/kernel/vmlinux.lds.S | 2 -- > include/asm-generic/sections.h | 6 +++--- > include/asm-generic/vmlinux.lds.h | 4 ++-- > mm/kmemleak.c | 2 +- > 5 files changed, 6 insertions(+), 9 deletions(-) For the s390 bits: Acked-by: Heiko Carstens