Re: [PATCH v7 13/13] MAINTAINERS: Add vfio-ccw maintainer

Cornelia Huck
2017-05-09T07:33:39Z

On Tue, 9 May 2017 09:41:43 +0800
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:

> * Cornelia Huck <cornelia.huck@de.ibm.com> [2017-05-08 11:09:27 +0200]:
>
> > On Mon, 8 May 2017 13:29:27 +0800
> > Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:
> >
> > > * Cornelia Huck <cornelia.huck@de.ibm.com> [2017-05-05 14:20:14 +0200]:
> > >
> > > > On Fri, 5 May 2017 04:03:52 +0200
> > > > Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:
> > > >
> > > > > Add Cornelia Huck as the vfio-ccw maintainer.
> > > > >
> > > > > Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
> > > > > ---
> > > > > MAINTAINERS | 5 +++++
> > > > > 1 file changed, 5 insertions(+)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index cae3b09..c1f9917 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -999,6 +999,11 @@ S: Supported
> > > > > F: hw/vfio/*
> > > > > F: include/hw/vfio/
> > > > >
> > > > > +vfio-ccw
> > > > > +M: Cornelia Huck <cornelia.huck@de.ibm.com>
> > > > > +S: Supported
> > > > > +F: hw/vfio/ccw.c
> > > >
> > > > The other code related to vfio-ccw is entangled with the other virtual
> > > > css code, so this is probably really the only file that needs to be
> > > > listed separately.
> > > "hw/s390x/" and "include/hw/s390x/" are listed under the "S390 Machines"
> > > part.
> > >
> > > Maybe you would like to list the following files separately here:
> > > hw/s390x/s390-ccw.c
> > > hw/s390x/s390-ccw.h
> >
> > Yes, that makes sense.
> >
> > But seeing the path name here: Should s390-ccw.h rather go into
> > include/hw/s390x/ (even if hw/s390x/ already contains several .h
> > files...)?
> Ok. You will find it in include/hw/s390x/ in next version.
>
> Would you like me making a sepate patch to move all of the other .h
> files to the include folder?

Let's just leave them where they are for now.