Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

Al Viro
2017-05-12T08:11:54Z

On Fri, May 12, 2017 at 09:43:40AM +0200, Arnd Bergmann wrote:

> How realistic and how useful would it be to first completely eliminate
> the ones that are in loadable modules and then wrapping the definition
> in #ifndef MODULE (or even make it an extern function)?

Eliminate _what_? ->read() and ->write() instances?

> This should be a fairly complete list of the modular users:
>
> drivers/block/drbd/drbd_main.c: set_fs(KERNEL_DS);

Ah, set_fs()... Sure, many of those can be killed off. Wouldn't be
a bad idea, but I don't understand what difference does modular/built-in
make here...

This one: AFAICS doesn't give a damn about set_fs() at all.

> drivers/input/serio/hp_sdc.c: set_fs(KERNEL_DS);

Open-coded probe_kernel_read(), apparently.

> drivers/media/v4l2-core/v4l2-compat-ioctl32.c: set_fs(KERNEL_DS);

massive compat ioctl crap.

> drivers/misc/lkdtm_bugs.c: set_fs(KERNEL_DS);

insane.

> drivers/s390/crypto/pkey_api.c: set_fs(KERNEL_DS);

No idea.

> drivers/staging/comedi/drivers/serial2002.c: set_fs(KERNEL_DS);

Open-coded kernel_write(); to some character device, no less... And similar
for kernel_read(), apparently.

> drivers/staging/lustre/lnet/libcfs/tracefile.c: set_fs(get_ds());

Fuck knows; kernel_write() might do it. Depends upon what it's writing
to.

You've missed other places in lustre, BTW - including the ioctls on
sockets, etc.

> drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:
> set_fs(KERNEL_DS);

Compat ioctl crap, again.

> drivers/staging/rtl8723bs/os_dep/osdep_service.c: oldfs
> = get_fs(); set_fs(get_ds());

Oh, lovely - reading an arbitrary (as in, specified by pathname) file.
Firmware (mis)handling?

> drivers/usb/gadget/function/f_mass_storage.c: set_fs(get_ds());

No idea.

> drivers/usb/gadget/function/u_uac1.c: set_fs(KERNEL_DS);

kernel_write(), by the look of it. Or something similar.

> drivers/vhost/vhost.c: set_fs(USER_DS);

kernel thread doing use_mm()

> drivers/video/fbdev/core/fbmem.c: set_fs(KERNEL_DS);

compat ioctl.

> drivers/video/fbdev/hpfb.c: set_fs(KERNEL_DS);

probe_kernel_read()

> fs/autofs4/waitq.c: set_fs(KERNEL_DS);

kernel_write()

> fs/binfmt_aout.c: set_fs(KERNEL_DS);
> fs/binfmt_elf.c: set_fs(USER_DS);
> fs/binfmt_elf_fdpic.c: set_fs(KERNEL_DS);

coredump stuff.

> fs/btrfs/send.c: set_fs(KERNEL_DS);
kernel_write()

Anyway, what's special about modules? IDGI...