Re: [PATCH net-next 4/4] s390/qeth: use diag26c to get MAC address on L2

David Miller
2017-06-19T14:48:23Z

From: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Date: Mon, 19 Jun 2017 13:22:25 +0200

> +{
> + struct diag26c_mac_req *request;
> + struct diag26c_mac_resp *response;
> + struct ccw_dev_id id;
> + int rc;
> +

Please order local variable declarations from longest to shortest
line (reverse christmas tree).

> + if ((request->resp_buf_len < sizeof(*response)) ||
> + (response->version != request->resp_version)) {

Excessive parenthesis here.

Thanks.