From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 15 Aug 2017 13:11:55 +0200 From: Cornelia Huck Subject: Re: [RFT 13/13] s390: virtio: constify ccw_device_id Message-ID: <20170815131155.4156a71d.cohuck@redhat.com> In-Reply-To: <1502793344-5368-14-git-send-email-arvind.yadav.cs@gmail.com> References: <1502793344-5368-1-git-send-email-arvind.yadav.cs@gmail.com> <1502793344-5368-14-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Arvind Yadav Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, sth@linux.vnet.ibm.com, hoeppner@linux.vnet.ibm.com, jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com, maier@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org List-ID: On Tue, 15 Aug 2017 16:05:44 +0530 Arvind Yadav wrote: > ccw_device_id are not supposed to change at runtime. All functions > working with ccw_device_id provided by work with > const ccw_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/s390/virtio/virtio_ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c > index b18fe20..b43dbba 100644 > --- a/drivers/s390/virtio/virtio_ccw.c > +++ b/drivers/s390/virtio/virtio_ccw.c > @@ -1307,7 +1307,7 @@ static int virtio_ccw_cio_notify(struct ccw_device *cdev, int event) > return rc; > } > > -static struct ccw_device_id virtio_ids[] = { > +static const struct ccw_device_id virtio_ids[] = { > { CCW_DEVICE(0x3832, 0) }, > {}, > }; Acked-by: Cornelia Huck