From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH RFC v3 2/9] KVM: arm/arm64: fix vcpu self-detection in vgic_v3_dispatch_sgi() Date: Tue, 29 Aug 2017 12:00:55 +0200 Message-ID: <20170829100055.GV24649@cbox> References: <20170821203530.9266-1-rkrcmar@redhat.com> <20170821203530.9266-3-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170821203530.9266-3-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Paolo Bonzini , David Hildenbrand , Marc Zyngier , Christian Borntraeger , Cornelia Huck , James Hogan , Paul Mackerras , Alexander Graf List-ID: On Mon, Aug 21, 2017 at 10:35:23PM +0200, Radim Krčmář wrote: > The index in kvm->vcpus array and vcpu->vcpu_id are very different > things. Comparing struct kvm_vcpu pointers is a sure way to know. > > Signed-off-by: Radim Krčmář Acked-by: Christoffer Dall > --- > virt/kvm/arm/vgic/vgic-mmio-v3.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/virt/kvm/arm/vgic/vgic-mmio-v3.c b/virt/kvm/arm/vgic/vgic-mmio-v3.c > index 408ef06638fc..9d4b69b766ec 100644 > --- a/virt/kvm/arm/vgic/vgic-mmio-v3.c > +++ b/virt/kvm/arm/vgic/vgic-mmio-v3.c > @@ -797,7 +797,6 @@ void vgic_v3_dispatch_sgi(struct kvm_vcpu *vcpu, u64 reg) > u16 target_cpus; > u64 mpidr; > int sgi, c; > - int vcpu_id = vcpu->vcpu_id; > bool broadcast; > > sgi = (reg & ICC_SGI1R_SGI_ID_MASK) >> ICC_SGI1R_SGI_ID_SHIFT; > @@ -821,7 +820,7 @@ void vgic_v3_dispatch_sgi(struct kvm_vcpu *vcpu, u64 reg) > break; > > /* Don't signal the calling VCPU */ > - if (broadcast && c == vcpu_id) > + if (broadcast && c_vcpu == vcpu) > continue; > > if (!broadcast) { > -- > 2.13.3 >