* [PATCH 18/36] perf s390: Always build with -fPIC [not found] <20171206144115.15097-1-acme@kernel.org> @ 2017-12-06 14:40 ` Arnaldo Carvalho de Melo 2017-12-07 8:09 ` Hendrik Brueckner 0 siblings, 1 reply; 3+ messages in thread From: Arnaldo Carvalho de Melo @ 2017-12-06 14:40 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, linux-perf-users, Hendrik Brueckner, Heiko Carstens, Martin Schwidefsky, Thomas Richter, linux s390 list, Arnaldo Carvalho de Melo From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> On s390, object files must be compiled with position-indepedent code in order to be incrementally linked or linked to shared libraries. Therefore, add -fPIC to the CFLAGS for s390 to ensure each object file is built properly. Reported-by: Jonathan Hermann <jonathan.hermann@de.ibm.com> Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Thomas Richter <tmricht@linux.vnet.ibm.com> Cc: linux s390 list <linux-s390@vger.kernel.org> LPU-Reference: 1512031765-9382-1-git-send-email-brueckner@linux.vnet.ibm.com Link: https://lkml.kernel.org/n/tip-a8wga8hrl0d0r84cal96fmgv@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Makefile.config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 2c437baf8364..bf86c09ca889 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -41,6 +41,7 @@ ifeq ($(SRCARCH),x86) LIBUNWIND_LIBS = -lunwind-x86 -llzma -lunwind endif NO_PERF_REGS := 0 + CFLAGS += -fPIC endif ifeq ($(SRCARCH),arm) -- 2.13.6 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 18/36] perf s390: Always build with -fPIC 2017-12-06 14:40 ` [PATCH 18/36] perf s390: Always build with -fPIC Arnaldo Carvalho de Melo @ 2017-12-07 8:09 ` Hendrik Brueckner 2017-12-28 15:34 ` [tip:perf/core] " tip-bot for Hendrik Brueckner 0 siblings, 1 reply; 3+ messages in thread From: Hendrik Brueckner @ 2017-12-07 8:09 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Ingo Molnar, linux-kernel, linux-perf-users, Hendrik Brueckner, Heiko Carstens, Martin Schwidefsky, Thomas Richter, linux s390 list, Arnaldo Carvalho de Melo Hi Arnaldo, On Wed, Dec 06, 2017 at 11:40:57AM -0300, Arnaldo Carvalho de Melo wrote: > From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> > > On s390, object files must be compiled with position-indepedent code in > order to be incrementally linked or linked to shared libraries. > Therefore, add -fPIC to the CFLAGS for s390 to ensure each object file > is built properly. > > Reported-by: Jonathan Hermann <jonathan.hermann@de.ibm.com> > Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: Thomas Richter <tmricht@linux.vnet.ibm.com> > Cc: linux s390 list <linux-s390@vger.kernel.org> > LPU-Reference: 1512031765-9382-1-git-send-email-brueckner@linux.vnet.ibm.com > Link: https://lkml.kernel.org/n/tip-a8wga8hrl0d0r84cal96fmgv@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > --- > tools/perf/Makefile.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index 2c437baf8364..bf86c09ca889 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -41,6 +41,7 @@ ifeq ($(SRCARCH),x86) > LIBUNWIND_LIBS = -lunwind-x86 -llzma -lunwind > endif > NO_PERF_REGS := 0 > + CFLAGS += -fPIC > endif I was just rebasing my syscall table work on top of your perf/core tree. It looks like that there is a significant difference compared to linux master tree. With f704ef44602fbf403e6722c7ed13f62d17e8cb20 ("s390/perf: add support for perf_regs and libdw"), Heiko introduced a change in the Makefile.config: --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -53,6 +53,10 @@ ifeq ($(SRCARCH),arm64) LIBUNWIND_LIBS = -lunwind -lunwind-aarch64 endif +ifeq ($(ARCH),s390) + NO_PERF_REGS := 0 +endif + ifeq ($(NO_PERF_REGS),0) The CFLAGS actually should applied to the s390 block and not in the x86 block. Somehow this got messed up with git cherryp-pick / am. So actually, this should go into the section above: diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index ed65e82..0833d9f 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -55,6 +55,7 @@ endif ifeq ($(ARCH),s390) NO_PERF_REGS := 0 + CFLAGS += -fPIC endif ifeq ($(NO_PERF_REGS),0) ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:perf/core] perf s390: Always build with -fPIC 2017-12-07 8:09 ` Hendrik Brueckner @ 2017-12-28 15:34 ` tip-bot for Hendrik Brueckner 0 siblings, 0 replies; 3+ messages in thread From: tip-bot for Hendrik Brueckner @ 2017-12-28 15:34 UTC (permalink / raw) To: linux-tip-commits Cc: acme, hpa, tglx, linux-kernel, mingo, tmricht, jonathan.hermann, heiko.carstens, brueckner, linux-s390, schwidefsky Commit-ID: a9a3f1d18a6c9ccf89728e23474645aa91e2f4f1 Gitweb: https://git.kernel.org/tip/a9a3f1d18a6c9ccf89728e23474645aa91e2f4f1 Author: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> AuthorDate: Wed, 13 Dec 2017 17:46:54 -0300 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 27 Dec 2017 12:15:57 -0300 perf s390: Always build with -fPIC On s390, object files must be compiled with position-indepedent code in order to be incrementally linked or linked to shared libraries. Therefore, add -fPIC to the CFLAGS for s390 to ensure each object file is built properly. Reported-by: Jonathan Hermann <jonathan.hermann@de.ibm.com> Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Thomas Richter <tmricht@linux.vnet.ibm.com> Cc: linux s390 list <linux-s390@vger.kernel.org> Link: https://lkml.kernel.org/r/20171207080951.GC4889@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Makefile.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index eb6bd99..f050f38 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -58,7 +58,7 @@ endif ifeq ($(ARCH),s390) NO_PERF_REGS := 0 NO_SYSCALL_TABLE := 0 - CFLAGS += -I$(OUTPUT)arch/s390/include/generated + CFLAGS += -fPIC -I$(OUTPUT)arch/s390/include/generated endif ifeq ($(NO_PERF_REGS),0) ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-28 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171206144115.15097-1-acme@kernel.org>
2017-12-06 14:40 ` [PATCH 18/36] perf s390: Always build with -fPIC Arnaldo Carvalho de Melo
2017-12-07 8:09 ` Hendrik Brueckner
2017-12-28 15:34 ` [tip:perf/core] " tip-bot for Hendrik Brueckner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).