linux-s390.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Bart Van Assche <Bart.VanAssche@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stefan Haberland <sth@linux.vnet.ibm.com>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk (also 4.12 stable)
Date: Thu, 7 Dec 2017 00:29:24 +0100	[thread overview]
Message-ID: <20171206232924.GA16584@lst.de> (raw)
In-Reply-To: <5ab91c56-b117-f4fa-3049-a4f8a5493155@de.ibm.com>

On Wed, Dec 06, 2017 at 01:25:11PM +0100, Christian Borntraeger wrote:
t > commit 11b2025c3326f7096ceb588c3117c7883850c068    -> bad
>     blk-mq: create a blk_mq_ctx for each possible CPU
> does not boot on DASD and 
> commit 9c6ae239e01ae9a9f8657f05c55c4372e9fc8bcc    -> good
>    genirq/affinity: assign vectors to all possible CPUs
> does boot with DASD disks.
> 
> Also adding Stefan Haberland if he has an idea why this fails on DASD and adding Martin (for the
> s390 irq handling code).

That is interesting as it really isn't related to interrupts at all,
it just ensures that possible CPUs are set in ->cpumask.

I guess we'd really want:

e005655c389e3d25bf3e43f71611ec12f3012de0
"blk-mq: only select online CPUs in blk_mq_hctx_next_cpu"

before this commit, but it seems like the whole stack didn't work for
your either.

I wonder if there is some weird thing about nr_cpu_ids in s390?

  reply	other threads:[~2017-12-06 23:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a1d51b13-c034-e0c8-9428-e360b2c898c3@kernel.dk>
     [not found] ` <20171123143453.GA29715@lst.de>
     [not found]   ` <cdca47a9-05cc-2676-57fe-904ce8ad5fbc@de.ibm.com>
     [not found]     ` <20171123182542.GA2680@lst.de>
     [not found]       ` <899f1638-cca4-28e6-3225-51505a053d45@de.ibm.com>
     [not found]         ` <20171123183232.GA2845@lst.de>
     [not found]           ` <92ef1aae-90b5-f14f-390e-bfab97899431@de.ibm.com>
     [not found]             ` <419d8565-9cbe-16ac-3d5d-5945098694bc@de.ibm.com>
     [not found]               ` <20171127155409.GA6937@lst.de>
     [not found]                 ` <d0f39408-b697-8d1a-2cce-b833cb8fa118@de.ibm.com>
     [not found]                   ` <20171204162108.GA12482@lst.de>
2017-12-06 12:25                     ` 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk (also 4.12 stable) Christian Borntraeger
2017-12-06 23:29                       ` Christoph Hellwig [this message]
2017-12-07  9:20                         ` Christian Borntraeger
2017-12-14 17:32                           ` Christian Borntraeger
2017-12-18 13:56                         ` Stefan Haberland
2017-12-20 15:47                           ` Christian Borntraeger
2018-01-11  9:13                             ` Ming Lei
2018-01-11  9:26                               ` Stefan Haberland
2018-01-11 11:44                               ` Christian Borntraeger
2018-01-11 13:17                                 ` Stefan Haberland
2018-01-11 17:46                               ` Christoph Hellwig
2018-01-12  1:16                                 ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206232924.GA16584@lst.de \
    --to=hch@lst.de \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=borntraeger@de.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sth@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).