Re: [PATCH 0/2] KVM: s390: fixups for cmma migration (kvm/master)

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 21 Dec 2017 13:26:45 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 12/21/2017 01:12 PM, Christian Borntraeger wrote:

> > If there is a bug in a piece of code it is certainly a good idea to look deeper....
> > I think we can prevent both bugs by something like
> > 
> > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> > index 8951ad4d33be..6ee12afced5a 100644
> > --- a/arch/s390/kvm/kvm-s390.c
> > +++ b/arch/s390/kvm/kvm-s390.c
> > @@ -841,6 +841,7 @@ static int kvm_s390_vm_stop_migration(struct kvm *kvm)
> >  
> >         if (kvm->arch.use_cmma) {
> >                 kvm_s390_sync_request_broadcast(kvm, KVM_REQ_STOP_MIGRATION);
> > +               synchronize_srcu(&kvm->srcu);
> >                 vfree(mgs->pgste_bitmap);
> >         }
> >         kfree(mgs);
> > 
> > 
> > Need to have a look.  
> 
> It needs a bit more changes for the get_cmma case.

Given that Christmas is approaching quickly: Get out the two fixes we
have now, worry about the rest later?