Re: [PATCH 03/12] s390/bitops: add test_and_clear_bit_inv()

David Hildenbrand
2018-01-16T20:13:09Z

On 16.01.2018 21:02, Christian Borntraeger wrote:
> From: Jens Freimann <jfrei@linux.vnet.ibm.com>
>
> This patch adds a MSB0 bit numbering version of test_and_clear_bit().
>
> Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
> Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/include/asm/bitops.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/s390/include/asm/bitops.h b/arch/s390/include/asm/bitops.h
> index 31e400c1a1f3..86e5b2fdee3c 100644
> --- a/arch/s390/include/asm/bitops.h
> +++ b/arch/s390/include/asm/bitops.h
> @@ -261,6 +261,11 @@ static inline void clear_bit_inv(unsigned long nr, volatile unsigned long *ptr)
> return clear_bit(nr ^ (BITS_PER_LONG - 1), ptr);
> }
>
> +static inline int test_and_clear_bit_inv(unsigned long nr, volatile unsigned long *ptr)
> +{
> + return test_and_clear_bit(nr ^ (BITS_PER_LONG - 1), ptr);
> +}
> +
> static inline void __set_bit_inv(unsigned long nr, volatile unsigned long *ptr)
> {
> return __set_bit(nr ^ (BITS_PER_LONG - 1), ptr);
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--

Thanks,

David / dhildenb