Re: [PATCH 02/12] KVM: s390: define GISA format-0 data structure

David Hildenbrand
2018-01-18T20:47:01Z

Two minor things

>
> +struct kvm_s390_gisa {
> + u32 next_alert;
> + u8 ipm;
> + u8 reserved01;
> + u8:6;

Mind giving this also a reserved name

> + u8 g:1;
> + u8 c:1;

Can you put spaces before/after the colon?

> + u8 iam;
> + u8 reserved02[4];
> + u32 airq_count;
> +};
> +
> /*

--

Thanks,

David / dhildenb