linux-s390.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net 0/1] net/iucv: fix 2018-03-13
@ 2018-03-13 15:50 Julian Wiedmann
  2018-03-13 15:50 ` [PATCH net 1/1] net/iucv: Free memory obtained by kzalloc Julian Wiedmann
  0 siblings, 1 reply; 3+ messages in thread
From: Julian Wiedmann @ 2018-03-13 15:50 UTC (permalink / raw)
  To: David Miller
  Cc: netdev, linux-s390, Martin Schwidefsky, Heiko Carstens,
	Stefan Raspl, Ursula Braun, Julian Wiedmann

Hi Dave,

please apply one patch for af_iucv, that fixes an error path during
initialization.

Thanks,
Julian


Arvind Yadav (1):
  net/iucv: Free memory obtained by kzalloc

 net/iucv/af_iucv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.13.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH net 1/1] net/iucv: Free memory obtained by kzalloc
  2018-03-13 15:50 [PATCH net 0/1] net/iucv: fix 2018-03-13 Julian Wiedmann
@ 2018-03-13 15:50 ` Julian Wiedmann
  2018-03-16 15:44   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Julian Wiedmann @ 2018-03-13 15:50 UTC (permalink / raw)
  To: David Miller
  Cc: netdev, linux-s390, Martin Schwidefsky, Heiko Carstens,
	Stefan Raspl, Ursula Braun, Julian Wiedmann

From: Arvind Yadav <arvind.yadav.cs@gmail.com>

Free memory by calling put_device(), if afiucv_iucv_init is not
successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
---
 net/iucv/af_iucv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index 1e8cc7bcbca3..9e2643ab4ccb 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void)
 	af_iucv_dev->driver = &af_iucv_driver;
 	err = device_register(af_iucv_dev);
 	if (err)
-		goto out_driver;
+		goto out_iucv_dev;
 	return 0;
 
+out_iucv_dev:
+	put_device(af_iucv_dev);
 out_driver:
 	driver_unregister(&af_iucv_driver);
 out_iucv:
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net 1/1] net/iucv: Free memory obtained by kzalloc
  2018-03-13 15:50 ` [PATCH net 1/1] net/iucv: Free memory obtained by kzalloc Julian Wiedmann
@ 2018-03-16 15:44   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-16 15:44 UTC (permalink / raw)
  To: jwi; +Cc: netdev, linux-s390, schwidefsky, heiko.carstens, raspl, ubraun

From: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Date: Tue, 13 Mar 2018 16:50:06 +0100

> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Free memory by calling put_device(), if afiucv_iucv_init is not
> successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
> Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-16 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 15:50 [PATCH net 0/1] net/iucv: fix 2018-03-13 Julian Wiedmann
2018-03-13 15:50 ` [PATCH net 1/1] net/iucv: Free memory obtained by kzalloc Julian Wiedmann
2018-03-16 15:44   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).