Re: [PATCH 08/10] vfio: ccw: Handling reset and shutdown with states

Cornelia Huck
2018-04-30T15:43:24Z

On Thu, 19 Apr 2018 16:48:11 +0200
Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:

> Two new events, VFIO_CCW_EVENT_ONLINE and VFIO_CCW_EVENT_OFFLINE
> allow to handle the enabling and disabling of a Sub Channel and
> the shutdown, quiesce and reset operations are changed accordingly.

OK, onlining/offlining via the fsm makes more sense conceptually than
the init event.

How is that supposed to play with enabling the subchannel in the init
event? I would rather expect it to be done in the onlining transition
only?

>
> Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_drv.c | 47 ++++++--------------------
> drivers/s390/cio/vfio_ccw_fsm.c | 66 +++++++++++++++++++++++++++++++++++++
> drivers/s390/cio/vfio_ccw_ops.c | 15 +++------
> drivers/s390/cio/vfio_ccw_private.h | 3 ++
> 4 files changed, 83 insertions(+), 48 deletions(-)