From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH] KVM: s390: vsie: BUG correction by shadow_crycb Date: Tue, 21 Aug 2018 16:42:43 +0200 Message-ID: <20180821164243.584e891f.cohuck@redhat.com> References: <1534861178-30372-1-git-send-email-pmorel@linux.ibm.com> <20180821163348.327ce02d.cohuck@redhat.com> <4c91cd0c-d679-eecc-0566-ed45158f6b7f@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4c91cd0c-d679-eecc-0566-ed45158f6b7f@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: David Hildenbrand Cc: Pierre Morel , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, borntraeger@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com List-ID: On Tue, 21 Aug 2018 16:36:19 +0200 David Hildenbrand wrote: > On 21.08.2018 16:33, Cornelia Huck wrote: > > On Tue, 21 Aug 2018 16:19:38 +0200 > > Pierre Morel wrote: > > > >> Copy the key mask to the right offset inside the shadow CRYCB > >> > >> Signed-off-by: Pierre Morel > >> --- > >> arch/s390/kvm/vsie.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c > >> index 63844b9..a2b28cd 100644 > >> --- a/arch/s390/kvm/vsie.c > >> +++ b/arch/s390/kvm/vsie.c > >> @@ -173,7 +173,8 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) > >> return set_validity_icpt(scb_s, 0x0039U); > >> > >> /* copy only the wrapping keys */ > >> - if (read_guest_real(vcpu, crycb_addr + 72, &vsie_page->crycb, 56)) > >> + if (read_guest_real(vcpu, crycb_addr + 72, > >> + vsie_page->crycb.dea_wrapping_key_mask, 56)) > > > > Don't you need the address here? > > As it is defined as an array, the address would result in the same value. > > (&vsie_page->crycb.dea_wrapping_key_mask[0]) /me looks... Indeed, it just looks a bit odd. With the changed subject Reviewed-by: Cornelia Huck > > > > >> return set_validity_icpt(scb_s, 0x0035U); > >> > >> scb_s->ecb3 |= ecb3_flags; > > > >