Re: [PATCH v11 24/26] KVM: s390: device attrs to enable/disable AP interpretation

Cornelia Huck
2018-09-26T13:44:46Z

On Tue, 25 Sep 2018 19:16:39 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:

> From: Tony Krowiak <akrowiak@linux.ibm.com>
>
> Introduces two new VM crypto device attributes (KVM_S390_VM_CRYPTO)
> to enable or disable AP instruction interpretation from userspace
> via the KVM_SET_DEVICE_ATTR ioctl:
>
> * The KVM_S390_VM_CRYPTO_ENABLE_APIE attribute enables hardware
> interpretation of AP instructions executed on the guest.
>
> * The KVM_S390_VM_CRYPTO_DISABLE_APIE attribute disables hardware
> interpretation of AP instructions executed on the guest. In this
> case the instructions will be intercepted and pass through to
> the guest.
>
> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
> ---
> arch/s390/include/uapi/asm/kvm.h | 2 ++
> arch/s390/kvm/kvm-s390.c | 31 ++++++++++++++++++++++++++++---
> 2 files changed, 30 insertions(+), 3 deletions(-)

Other than the nits that David had, this looks fine.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>