From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Date: Fri, 12 Oct 2018 14:09:06 +0300 Message-ID: <20181012110906.fpfttp4nhvsr2ps7@kshutemo-mobl1> References: <20181012013756.11285-1-joel@joelfernandes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane.org@lists.infradead.org List-Archive: List-Post: To: "Joel Fernandes (Google)" Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, lokeshgidra@google.com, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, elfring@users.sourceforge.net, Jonas Bonn , linux-s390@vger.kernel.org, dancol@google.com, Yoshinori Sato , linux-xtensa@linux-xtensa.org, linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , hughd@google.com, "James E.J. Bottomley" , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ingo Molnar List-ID: On Thu, Oct 11, 2018 at 06:37:55PM -0700, Joel Fernandes (Google) wrote: > diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h > index 12fe700632f4..4399d712f6db 100644 > --- a/arch/m68k/include/asm/mcf_pgalloc.h > +++ b/arch/m68k/include/asm/mcf_pgalloc.h > @@ -12,8 +12,7 @@ extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > > extern const char bad_pmd_string[]; > > -extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, > - unsigned long address) > +extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > { > unsigned long page = __get_free_page(GFP_DMA); > > @@ -32,8 +31,6 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) > #define pmd_alloc_one_fast(mm, address) ({ BUG(); ((pmd_t *)1); }) > #define pmd_alloc_one(mm, address) ({ BUG(); ((pmd_t *)2); }) > > -#define pte_alloc_one_fast(mm, addr) pte_alloc_one(mm, addr) > - I believe this was one done manually, right? Please explicitely state everthing you did on not of sematic patch ... > diff --git a/arch/microblaze/include/asm/pgalloc.h b/arch/microblaze/include/asm/pgalloc.h > index 7c89390c0c13..f4cc9ffc449e 100644 > --- a/arch/microblaze/include/asm/pgalloc.h > +++ b/arch/microblaze/include/asm/pgalloc.h > @@ -108,10 +108,9 @@ static inline void free_pgd_slow(pgd_t *pgd) > #define pmd_alloc_one_fast(mm, address) ({ BUG(); ((pmd_t *)1); }) > #define pmd_alloc_one(mm, address) ({ BUG(); ((pmd_t *)2); }) > > -extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm, unsigned long addr); > +extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); > > -static inline struct page *pte_alloc_one(struct mm_struct *mm, > - unsigned long address) > +static inline struct page *pte_alloc_one(struct mm_struct *mm) > { > struct page *ptepage; > > @@ -132,20 +131,6 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm, > return ptepage; > } > > -static inline pte_t *pte_alloc_one_fast(struct mm_struct *mm, > - unsigned long address) > -{ > - unsigned long *ret; > - > - ret = pte_quicklist; > - if (ret != NULL) { > - pte_quicklist = (unsigned long *)(*ret); > - ret[0] = 0; > - pgtable_cache_size--; > - } > - return (pte_t *)ret; > -} > - Ditto. -- Kirill A. Shutemov