Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions

Joel Fernandes
2018-10-12T16:37:25Z

On Fri, Oct 12, 2018 at 02:09:06PM +0300, Kirill A. Shutemov wrote:
> On Thu, Oct 11, 2018 at 06:37:55PM -0700, Joel Fernandes (Google) wrote:
> > diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h
> > index 12fe700632f4..4399d712f6db 100644
> > --- a/arch/m68k/include/asm/mcf_pgalloc.h
> > +++ b/arch/m68k/include/asm/mcf_pgalloc.h
> > @@ -12,8 +12,7 @@ extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)
> >
> > extern const char bad_pmd_string[];
> >
> > -extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm,
> > - unsigned long address)
> > +extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm)
> > {
> > unsigned long page = __get_free_page(GFP_DMA);
> >
> > @@ -32,8 +31,6 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address)
> > #define pmd_alloc_one_fast(mm, address) ({ BUG(); ((pmd_t *)1); })
> > #define pmd_alloc_one(mm, address) ({ BUG(); ((pmd_t *)2); })
> >
> > -#define pte_alloc_one_fast(mm, addr) pte_alloc_one(mm, addr)
> > -
>
> I believe this was one done manually, right?
> Please explicitely state everthing you did on not of sematic patch

Ok, I can update the changelog with that information next time I send it.
This is the only thing I didn't mention in the changelog since it was a
trivial unused function deletion.. but I mentioned everything else..

And sir, you are one thorough reviewer! ;-)

- Joel

[..]