From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 23 Nov 2018 11:17:48 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH] s390: Remove obsolete bust_spinlock() implementation Message-ID: <20181123021748.GB1582@jagdpanzerIV> References: <20181122141529.14933-1-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181122141529.14933-1-pmladek@suse.com> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Petr Mladek Cc: Martin Schwidefsky , Heiko Carstens , Sergey Senozhatsky , Steven Rostedt , Sergey Senozhatsky , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: On (11/22/18 15:15), Petr Mladek wrote: > The commit cefc8be82403cf ("Consolidate bust_spinlocks()") kept > the s390-specific implementation because of the absence of CONFIG_VT. > In fact, the only difference was calling console_unblank() instead of > unblank_screen(). > > The common implementation in lib/bust_spinlocks.c started to call > unblank_screen() explicitly since the commit b61312d353da187 > ("oops handling: ensure that any oops is flushed to the mtdoops > console"). > > As a result, the custom implementation is not longer necessary. > And we could get all the other improvements of the common > implementation for free. I believe I sent a similar patch several weeks ago and it's in s390 patch queue as of now, waiting for the next merge window. lkml.kernel.org/r/20181025081108.GB26561@osiris -ss