From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 16 Jan 2019 16:39:48 +0100 From: Greg KH Subject: Re: [PATCH 2/7] coresight: perf: Add "sinks" group to PMU directory Message-ID: <20190116153948.GC871@kroah.com> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> <20190115230742.13730-3-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190115230742.13730-3-mathieu.poirier@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org List-Archive: To: Mathieu Poirier Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org, suzuki.poulose@arm.com, peterz@infradead.org, will.deacon@arm.com, heiko.carstens@de.ibm.com, adrian.hunter@intel.com, acme@kernel.org, ast@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, linux-arm-kernel@lists.infradead.org, hpa@zytor.com, schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de, jolsa@redhat.com, linux-kernel@vger.kernel.org List-ID: On Tue, Jan 15, 2019 at 04:07:37PM -0700, Mathieu Poirier wrote: > Add a "sinks" directory entry so that users can see all the sinks > available in the system in a single place. Individual sink are added > as they are registered with the coresight bus. > > Signed-off-by: Mathieu Poirier > --- > .../hwtracing/coresight/coresight-etm-perf.c | 43 +++++++++++++++++++ > .../hwtracing/coresight/coresight-etm-perf.h | 1 + > drivers/hwtracing/coresight/coresight.c | 17 ++++++++ > 3 files changed, 61 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index f21eb28b6782..292bd409a68c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -43,8 +44,18 @@ static const struct attribute_group etm_pmu_format_group = { > .attrs = etm_config_formats_attr, > }; > > +static struct attribute *etm_config_sinks_attr[] = { > + NULL, > +}; > + > +static const struct attribute_group etm_pmu_sinks_group = { > + .name = "sinks", > + .attrs = etm_config_sinks_attr, > +}; > + > static const struct attribute_group *etm_pmu_attr_groups[] = { > &etm_pmu_format_group, > + &etm_pmu_sinks_group, > NULL, > }; > > @@ -479,6 +490,38 @@ int etm_perf_symlink(struct coresight_device *csdev, bool link) > return 0; > } > > +static ssize_t etm_perf_sink_name_show(struct device *dev, > + struct device_attribute *dattr, > + char *buf) > +{ > + /* See function coresight_sink_by_id() to know where this is used */ > + u32 hash = hashlen_hash(hashlen_string(NULL, dattr->attr.name)); > + > + return scnprintf(buf, PAGE_SIZE, "%x\n", hash); > +} > + > +int etm_perf_symlink_sink(struct coresight_device *csdev) > +{ > + struct device *pmu_dev = etm_pmu.dev; > + struct device *pdev = csdev->dev.parent; > + struct device_attribute *dev_attr; > + > + if (csdev->type != CORESIGHT_DEV_TYPE_SINK && > + csdev->type != CORESIGHT_DEV_TYPE_LINKSINK) > + return -EINVAL; > + > + if (!etm_perf_up) > + return -EPROBE_DEFER; > + > + dev_attr = kzalloc(sizeof(*dev_attr), GFP_KERNEL); > + dev_attr->attr.name = kstrdup(dev_name(pdev), GFP_KERNEL); > + dev_attr->attr.mode = 0444; > + dev_attr->show = etm_perf_sink_name_show; > + > + return sysfs_add_file_to_group(&pmu_dev->kobj, > + &dev_attr->attr, "sinks"); What is so odd about this call that you needed me to review this? And what happens if this call fails, do you leak memory? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel