From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 23 Jan 2019 22:05:07 +0100 From: Peter Zijlstra Subject: Re: [PATCH 3/7] coresight: Use event attributes for sink selection Message-ID: <20190123210507.GA17767@hirez.programming.kicks-ass.net> References: <20190115230742.13730-1-mathieu.poirier@linaro.org> <20190115230742.13730-4-mathieu.poirier@linaro.org> <20190123210333.GZ27931@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190123210333.GZ27931@hirez.programming.kicks-ass.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org List-Archive: To: Mathieu Poirier Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org, suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, heiko.carstens@de.ibm.com, adrian.hunter@intel.com, acme@kernel.org, ast@kernel.org, mingo@redhat.com, will.deacon@arm.com, hpa@zytor.com, schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de, jolsa@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-ID: On Wed, Jan 23, 2019 at 10:03:33PM +0100, Peter Zijlstra wrote: > On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote: > > + /* First get the selected sink from user space. */ > > + sink = coresight_get_sink_by_id(event->attr.config2); > > (I know there's a new version out, I'll go look there shortly) > > should this patch not also have something like: > > PMU_FORMAT_ATTR(sinkid, "config2:0-63"); n/m, I see it's already there. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel