Re: [PATCH v6 07/13] KVM: s390: introduce struct kvm_s390_gisa_interrupt

Michael Mueller
2019-01-24T15:24:28Z

On 24.01.19 16:06, Cornelia Huck wrote:
> On Thu, 24 Jan 2019 13:59:33 +0100
> Michael Mueller <mimu@linux.ibm.com> wrote:
>
>> Use this struct analog to the kvm interruption structs
>> for kvm emulated floating and local interruptions.
>
> I guess that makes sense.
>
>> Further fields will be added with this series as
>> required.
>
> A reference to "this series" will look a bit strange if you look at the
> committed patch later. What about:
>
> "GIB handling will add further fields to this structure as required."

Yes, that reads pretty well. I will replace the sentence.

>
> ?
>
>>
>> Signed-off-by: Michael Mueller <mimu@linux.ibm.com>
>> ---
>> arch/s390/include/asm/kvm_host.h | 6 ++++-
>> arch/s390/kvm/interrupt.c | 52 +++++++++++++++++++++++-----------------
>> arch/s390/kvm/kvm-s390.c | 2 +-
>> 3 files changed, 36 insertions(+), 24 deletions(-)
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>