From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=KKla=QI=vger.kernel.org=linux-kernel-owner@kernel.org>
Date: Fri, 1 Feb 2019 10:01:59 +0100
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command
References: <1548870526-30595-1-git-send-email-akrowiak@linux.ibm.com>
 <alpine.LFD.2.21.1901301912380.2372@schleppi>
 <88b72363-9dca-4653-c326-9c37b6349a32@linux.ibm.com>
MIME-Version: 1.0
In-Reply-To: <88b72363-9dca-4653-c326-9c37b6349a32@linux.ibm.com>
Message-Id: <20190201090159.GC3770@osiris>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-Archive: <https://lore.kernel.org/lkml/>
List-Post: <mailto:linux-kernel@vger.kernel.org>
To: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Sebastian Ott <sebott@linux.ibm.com>, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Schwidefsky <schwidefsky@de.ibm.com>, oberpar@linux.ibm.com, freude@linux.ibm.com, pmorel@linux.ibm.com, pasic@linux.ibm.com, cohuck@redhat.com
List-ID: <linux-s390.vger.kernel.org>

On Thu, Jan 31, 2019 at 06:28:39PM -0500, Tony Krowiak wrote:
> On 1/30/19 1:32 PM, Sebastian Ott wrote:
> >On Wed, 30 Jan 2019, Tony Krowiak wrote:
> >>+#if IS_ENABLED(CONFIG_ZCRYPT)
> >>+void ap_bus_cfg_chg(void);
> >>+#else
> >>+#error "no CONFIG_ZCRYPT"
> >    ^
> >I don't think that's the right thing to do here.
> 
> I'd like to leave it. If somebody edits .config
> and sets CONFIG_ZCRYPT=n, then the build will
> fail. The preprocessor error above tells them
> why.

No, the kernel build should never fail if a config option is not set.
Also the above should be "#ifdef CONFIG_ZCRYPT".

In addition (this isn't quoted unfortunately) the alternative function
in the header file is missing the "inline" attribute. Can you please
add that too?

static inline void ap_bus_cfg_chg(void) { }

> >>+* A config change has happened, Force an ap bus rescan.
> >>+*/
> >>+void ap_bus_cfg_chg(void)
> >>+{
> >>+	AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__);
> >>+
> >>+	ap_bus_force_rescan();
> >>+}
> >>+EXPORT_SYMBOL(ap_bus_cfg_chg);
> >
> >There is no need for the export symbol - you don't call that function
> >from module code.
> >As an unrelated question, just to be sure: ap_bus.c is compiled as
> >built-in even with ZCRYPT=m, right?
> 
> No. If you edit .config and set CONFIG_ZCRYPT=m, ap_bus.c will be built
> into the zcrypt.ko module. Through some other magic, the zcrypt module
> is loaded when linux boots.

If that happens, then we have a build problem that needs to be
fixed. What exactly are you doing to get the ap code linked into the
zcrypt module?