Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

Jiri Kosina
2019-04-04T19:49:05Z

On Thu, 4 Apr 2019, Josh Poimboeuf wrote:

> Configure powerpc CPU runtime speculation bug mitigations in accordance
> with the 'cpu_spec_mitigations=' cmdline options. This affects
> Meltdown, Spectre v1, Spectre v2, and Speculative Store Bypass.
[ ... snip ... ]
> - if (!no_nospec)
> + if (!no_nospec && cpu_spec_mitigations != CPU_SPEC_MITIGATIONS_OFF)

'!no_nospec' is something that I am sure will come back to hunt me in my
bad dreams.

But that's been there already, and fixing it is out of scope of this
patch. Other than that, as discussed previously -- I really like this new
global option. Feel free to add

Reviewed-by: Jiri Kosina <jkosina@suse.cz>

for the whole set.

Thanks,

--
Jiri Kosina
SUSE Labs