From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 10 Apr 2019 17:58:19 +0200 From: Martin Schwidefsky Subject: Re: [PATCH 04/12] s390: qeth: address type mismatch warning In-Reply-To: <20190408212648.2407234-4-arnd@arndb.de> References: <20190408212648.2407234-1-arnd@arndb.de> <20190408212648.2407234-4-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20190410175819.106f30b3@mschwideX1> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Arnd Bergmann Cc: Heiko Carstens , Julian Wiedmann , Ursula Braun , clang-built-linux@googlegroups.com, Nick Desaulniers , Nathan Chancellor , linux-s390@vger.kernel.org, "David S. Miller" , Kittipon Meesompop , linux-kernel@vger.kernel.org List-ID: On Mon, 8 Apr 2019 23:26:17 +0200 Arnd Bergmann wrote: > clang produces a harmless warning for each use for the qeth_adp_supported > macro: > > drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from enumeration type 'enum qeth_ipa_setadp_cmd' to > different enumeration type 'enum qeth_ipa_funcs' [-Wenum-conversion] > if (qeth_adp_supported(card, IPA_SETADP_SET_PROMISC_MODE)) > ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/s390/net/qeth_core.h:179:41: note: expanded from macro 'qeth_adp_supported' > qeth_is_ipa_supported(&c->options.adp, f) > ~~~~~~~~~~~~~~~~~~~~~ ^ > > Add a version of this macro that uses the correct types, and > remove the unused qeth_adp_enabled() macro that has the same > problem. > > Signed-off-by: Arnd Bergmann I have added this to our internal tree for Julian to pick up. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.