From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 3 May 2019 11:44:50 +0200 From: Cornelia Huck Subject: Re: [PATCH 03/10] virtio/s390: enable packed ring Message-ID: <20190503114450.2512b121.cohuck@redhat.com> In-Reply-To: <20190426183245.37939-4-pasic@linux.ibm.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-4-pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Halil Pasic Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman List-ID: On Fri, 26 Apr 2019 20:32:38 +0200 Halil Pasic wrote: > Nothing precludes to accepting VIRTIO_F_RING_PACKED any more. "precludes us from accepting" > > Signed-off-by: Halil Pasic > --- > drivers/s390/virtio/virtio_ccw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c > index 42832a164546..6d989c360f38 100644 > --- a/drivers/s390/virtio/virtio_ccw.c > +++ b/drivers/s390/virtio/virtio_ccw.c > @@ -773,10 +773,8 @@ static u64 virtio_ccw_get_features(struct virtio_device *vdev) > static void ccw_transport_features(struct virtio_device *vdev) > { > /* > - * There shouldn't be anything that precludes supporting packed. > - * TODO: Remove the limitation after having another look into this. > + * Currently nothing to do here. > */ > - __virtio_clear_bit(vdev, VIRTIO_F_RING_PACKED); > } > > static int virtio_ccw_finalize_features(struct virtio_device *vdev) Not sure whether we should merge this into the previous patch instead. Anyway, I think we can go ahead with that for 5.2 as well. Reviewed-by: Cornelia Huck