* [PATCH] s390: vdso: drop unnecessary cc-ldoption
@ 2019-04-23 21:00 Nick Desaulniers
2019-04-30 20:25 ` Nick Desaulniers
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2019-04-23 21:00 UTC (permalink / raw)
To: schwidefsky, heiko.carstens
Cc: Nick Desaulniers, clang-built-linux, Masahiro Yamada,
Vasily Gorbik, Philipp Rudo, linux-s390, linux-kernel
Towards the goal of removing cc-ldoption, it seems that --hash-style=
was added to binutils 2.17.50.0.2 in 2006. The minimal required version
of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.
Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
Cc: clang-built-linux@googlegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/s390/kernel/vdso32/Makefile | 2 +-
arch/s390/kernel/vdso64/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/vdso32/Makefile b/arch/s390/kernel/vdso32/Makefile
index e76309fbbcb3..aee9ffbccb54 100644
--- a/arch/s390/kernel/vdso32/Makefile
+++ b/arch/s390/kernel/vdso32/Makefile
@@ -19,7 +19,7 @@ KBUILD_AFLAGS_31 += -m31 -s
KBUILD_CFLAGS_31 := $(filter-out -m64,$(KBUILD_CFLAGS))
KBUILD_CFLAGS_31 += -m31 -fPIC -shared -fno-common -fno-builtin
KBUILD_CFLAGS_31 += -nostdlib -Wl,-soname=linux-vdso32.so.1 \
- $(call cc-ldoption, -Wl$(comma)--hash-style=both)
+ -Wl,--hash-style=both
$(targets:%=$(obj)/%.dbg): KBUILD_CFLAGS = $(KBUILD_CFLAGS_31)
$(targets:%=$(obj)/%.dbg): KBUILD_AFLAGS = $(KBUILD_AFLAGS_31)
diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile
index f849ac61c5da..bec19e7e6e1c 100644
--- a/arch/s390/kernel/vdso64/Makefile
+++ b/arch/s390/kernel/vdso64/Makefile
@@ -19,7 +19,7 @@ KBUILD_AFLAGS_64 += -m64 -s
KBUILD_CFLAGS_64 := $(filter-out -m64,$(KBUILD_CFLAGS))
KBUILD_CFLAGS_64 += -m64 -fPIC -shared -fno-common -fno-builtin
KBUILD_CFLAGS_64 += -nostdlib -Wl,-soname=linux-vdso64.so.1 \
- $(call cc-ldoption, -Wl$(comma)--hash-style=both)
+ -Wl,--hash-style=both
$(targets:%=$(obj)/%.dbg): KBUILD_CFLAGS = $(KBUILD_CFLAGS_64)
$(targets:%=$(obj)/%.dbg): KBUILD_AFLAGS = $(KBUILD_AFLAGS_64)
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: vdso: drop unnecessary cc-ldoption
2019-04-23 21:00 [PATCH] s390: vdso: drop unnecessary cc-ldoption Nick Desaulniers
@ 2019-04-30 20:25 ` Nick Desaulniers
2019-05-03 14:39 ` Heiko Carstens
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2019-04-30 20:25 UTC (permalink / raw)
To: Martin Schwidefsky, Heiko Carstens
Cc: clang-built-linux, Masahiro Yamada, Vasily Gorbik, Philipp Rudo,
linux-s390, LKML
On Tue, Apr 23, 2019 at 2:01 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
>
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/s390/kernel/vdso32/Makefile | 2 +-
> arch/s390/kernel/vdso64/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/kernel/vdso32/Makefile b/arch/s390/kernel/vdso32/Makefile
> index e76309fbbcb3..aee9ffbccb54 100644
> --- a/arch/s390/kernel/vdso32/Makefile
> +++ b/arch/s390/kernel/vdso32/Makefile
> @@ -19,7 +19,7 @@ KBUILD_AFLAGS_31 += -m31 -s
> KBUILD_CFLAGS_31 := $(filter-out -m64,$(KBUILD_CFLAGS))
> KBUILD_CFLAGS_31 += -m31 -fPIC -shared -fno-common -fno-builtin
> KBUILD_CFLAGS_31 += -nostdlib -Wl,-soname=linux-vdso32.so.1 \
> - $(call cc-ldoption, -Wl$(comma)--hash-style=both)
> + -Wl,--hash-style=both
>
> $(targets:%=$(obj)/%.dbg): KBUILD_CFLAGS = $(KBUILD_CFLAGS_31)
> $(targets:%=$(obj)/%.dbg): KBUILD_AFLAGS = $(KBUILD_AFLAGS_31)
> diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile
> index f849ac61c5da..bec19e7e6e1c 100644
> --- a/arch/s390/kernel/vdso64/Makefile
> +++ b/arch/s390/kernel/vdso64/Makefile
> @@ -19,7 +19,7 @@ KBUILD_AFLAGS_64 += -m64 -s
> KBUILD_CFLAGS_64 := $(filter-out -m64,$(KBUILD_CFLAGS))
> KBUILD_CFLAGS_64 += -m64 -fPIC -shared -fno-common -fno-builtin
> KBUILD_CFLAGS_64 += -nostdlib -Wl,-soname=linux-vdso64.so.1 \
> - $(call cc-ldoption, -Wl$(comma)--hash-style=both)
> + -Wl,--hash-style=both
>
> $(targets:%=$(obj)/%.dbg): KBUILD_CFLAGS = $(KBUILD_CFLAGS_64)
> $(targets:%=$(obj)/%.dbg): KBUILD_AFLAGS = $(KBUILD_AFLAGS_64)
> --
> 2.21.0.593.g511ec345e18-goog
>
bumping for review
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: vdso: drop unnecessary cc-ldoption
2019-04-30 20:25 ` Nick Desaulniers
@ 2019-05-03 14:39 ` Heiko Carstens
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2019-05-03 14:39 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Martin Schwidefsky, clang-built-linux, Masahiro Yamada,
Vasily Gorbik, Philipp Rudo, linux-s390, LKML
On Tue, Apr 30, 2019 at 01:25:09PM -0700, Nick Desaulniers wrote:
> On Tue, Apr 23, 2019 at 2:01 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > Towards the goal of removing cc-ldoption, it seems that --hash-style=
> > was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> > of binutils for the kernel according to
> > Documentation/process/changes.rst is 2.20.
> >
> > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> > Cc: clang-built-linux@googlegroups.com
> > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > ---
> > arch/s390/kernel/vdso32/Makefile | 2 +-
> > arch/s390/kernel/vdso64/Makefile | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
...
> bumping for review
Sorry for the delay! Applied now, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-03 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-23 21:00 [PATCH] s390: vdso: drop unnecessary cc-ldoption Nick Desaulniers
2019-04-30 20:25 ` Nick Desaulniers
2019-05-03 14:39 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).