From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 15 May 2019 19:23:44 +0200 From: Halil Pasic Subject: Re: [PATCH 10/10] virtio/s390: make airq summary indicators DMA In-Reply-To: <7c21b646-df27-88b6-6b06-3aab7887ff0a@linux.ibm.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-11-pasic@linux.ibm.com> <74ff9a63-891a-7e24-0865-8cc91a95cada@linux.ibm.com> <7c21b646-df27-88b6-6b06-3aab7887ff0a@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20190515192344.5c57724c.pasic@linux.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Michael Mueller Cc: pmorel@linux.ibm.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman List-ID: On Wed, 15 May 2019 15:33:02 +0200 Michael Mueller wrote: > >> @@ -273,8 +281,9 @@ static unsigned long get_airq_indicator(struct > >> virtqueue *vqs[], int nvqs, > >>       unsigned long bit, flags; > >>       for (i = 0; i < MAX_AIRQ_AREAS && !indicator_addr; i++) { > >> +        /* TODO: this seems to be racy */ > > > > yes, my opinions too, was already racy, in my opinion, we need another > > patch in another series to fix this. > > > > However, not sure about the comment. > > I will drop this comment for v2 of this patch series. > We shall fix the race with a separate patch. Unless there is somebody eager to address this real soon, I would prefer keeping the comment as a reminder. Thanks for shouldering the v2! Regards, Halil