Re: [PATCH v2 2/8] s390/cio: introduce DMA pools to cio

Michael Mueller
2019-05-27T11:26:45Z

On 25.05.19 11:22, Sebastian Ott wrote:
>
> On Thu, 23 May 2019, Michael Mueller wrote:
>> +static void __init cio_dma_pool_init(void)
>> +{
>> + /* No need to free up the resources: compiled in */
>> + cio_dma_pool = cio_gp_dma_create(cio_get_dma_css_dev(), 1);
>
> This can return NULL.

css_bus_init() will fail with -ENOMEM in v3

>
>> +/**
>> + * Allocate dma memory from the css global pool. Intended for memory not
>> + * specific to any single device within the css. The allocated memory
>> + * is not guaranteed to be 31-bit addressable.
>> + *
>> + * Caution: Not suitable for early stuff like console.
>> + *
>> + */
>
> drivers/s390/cio/css.c:1121: warning: Function parameter or member 'size' not described in 'cio_dma_zalloc'

will complete param description in v3

>
> Reviewed-by: Sebastian Ott <sebott@linux.ibm.com>

Thanks!

>

Michael