From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 31 May 2019 11:50:55 +0200 From: Cornelia Huck Subject: Re: [PATCH v1] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP Message-ID: <20190531115055.7f5cf64e.cohuck@redhat.com> In-Reply-To: <20190531093628.14766-1-david@redhat.com> References: <20190531093628.14766-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: To: David Hildenbrand Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Harald Freudenberger , Heiko Carstens , Christian Borntraeger On Fri, 31 May 2019 11:36:28 +0200 David Hildenbrand wrote: > systemd-modules-load.service automatically tries to load the pkey module > on systems that have MSA. > > Pkey also requires the MSA3 facility and a bunch of subfunctions. > Failing with -EOPNOTSUPP makes "systemd-modules-load.service" fail on > any system that does not have all needed subfunctions. For example, > when running under QEMU TCG (but also on systems where protected keys > are disabled via the HMC). > > Let's use -ENODEV, so systemd-modules-load.service properly ignores > failing to load the pkey module because of missing HW functionality. > > Cc: Harald Freudenberger > Cc: Heiko Carstens > Cc: Cornelia Huck > Cc: Christian Borntraeger > Signed-off-by: David Hildenbrand > --- > drivers/s390/crypto/pkey_api.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Looking at what other modules return when needed features are missing, this looks like the right thing to do. Reviewed-by: Cornelia Huck