Re: [PATCH v2 4/9] s390/cio: Use generalized CCW handler in cp_init()

Cornelia Huck
2019-06-12T11:18:54Z

On Thu, 6 Jun 2019 22:28:26 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> It is now pretty apparent that ccwchain_handle_ccw()
> (nee ccwchain_handle_tic()) does everything that cp_init()
> wants to do.
>
> Let's remove that duplicated code from cp_init() and let
> ccwchain_handle_ccw() handle it itself.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 27 ++++-----------------------
> 1 file changed, 4 insertions(+), 23 deletions(-)

Nice cleanup :)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>