From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:47586 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405826AbfFLLHm (ORCPT ); Wed, 12 Jun 2019 07:07:42 -0400 Date: Wed, 12 Jun 2019 13:07:35 +0200 From: Cornelia Huck Subject: Re: [PATCH v2 1/9] s390/cio: Squash cp_free() and cp_unpin_free() Message-ID: <20190612130735.192696f4.cohuck@redhat.com> In-Reply-To: <20190606202831.44135-2-farman@linux.ibm.com> References: <20190606202831.44135-1-farman@linux.ibm.com> <20190606202831.44135-2-farman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Eric Farman Cc: Farhan Ali , Halil Pasic , linux-s390@vger.kernel.org, kvm@vger.kernel.org On Thu, 6 Jun 2019 22:28:23 +0200 Eric Farman wrote: > The routine cp_free() does nothing but call cp_unpin_free(), and while > most places call cp_free() there is one caller of cp_unpin_free() used > when the cp is guaranteed to have not been marked initialized. > > This seems like a dubious way to make a distinction, so let's combine > these routines and make cp_free() do all the work. Prior to the introduction of ->initialized, cp_free() only was a wrapper around cp_unpin_free(), which made even less sense... but checking ->initialized does not really matter at all here. > > Signed-off-by: Eric Farman > --- > The RFC version of this patch received r-b's from Farhan [1] and > Pierre [2]. This patch is almost identical to that one, but I > opted to not include those tags because of the cp->initialized > check that now has an impact here. I still think this patch makes > sense, but want them (well, Farhan) to have a chance to look it > over since it's been six or seven months. > > [1] https://patchwork.kernel.org/comment/22310411/ > [2] https://patchwork.kernel.org/comment/22317927/ > --- > drivers/s390/cio/vfio_ccw_cp.c | 36 +++++++++++++++------------------- > 1 file changed, 16 insertions(+), 20 deletions(-) Reviewed-by: Cornelia Huck