Re: [PATCH v2 7/9] vfio-ccw: Remove pfn_array_table

Cornelia Huck
2019-06-13T16:03:08Z

On Thu, 6 Jun 2019 22:28:29 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> Now that both CCW codepaths build this nested array:
>
> ccwchain->pfn_array_table[1]->pfn_array[#idaws/#pages]
>
> We can collapse this into simply:
>
> ccwchain->pfn_array[#idaws/#pages]
>
> Let's do that, so that we don't have to continually navigate two
> nested arrays when the first array always has a count of one.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 118 +++++++++------------------------
> 1 file changed, 33 insertions(+), 85 deletions(-)

That's how I like my diffstats :) Nice cleanup!

Reviewed-by: Cornelia Huck <cohuck@redhat.com>