Re: [RFC PATCH v1 3/5] vfio-ccw: Copy CCW data outside length calculation

Cornelia Huck
2019-06-19T08:18:22Z

On Tue, 18 Jun 2019 22:23:50 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> It doesn't make much sense to "hide" the copy to the channel_program
> struct inside a routine that calculates the length of the chain.
>
> Let's move it to the calling routine, which will later copy from
> channel_program to the memory it allocated itself.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>