Re: [PATCH] s390/cio: introduce driver_override on the css bus

Cornelia Huck
2019-06-21T14:05:57Z

On Fri, 21 Jun 2019 15:37:11 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:

> On Fri, 21 Jun 2019 11:56:04 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
> > On Thu, 13 Jun 2019 13:08:15 +0200
> > Cornelia Huck <cohuck@redhat.com> wrote:
> >
> > > Sometimes, we want to control which of the matching drivers
> > > binds to a subchannel device (e.g. for subchannels we want to
> > > handle via vfio-ccw).
> > >
> > > For pci devices, a mechanism to do so has been introduced in
> > > 782a985d7af2 ("PCI: Introduce new device binding path using
> > > pci_dev.driver_override"). It makes sense to introduce the
> > > driver_override attribute for subchannel devices as well, so
> > > that we can easily extend the 'driverctl' tool (which makes
> > > use of the driver_override attribute for pci).
> > >
> > > Note that unlike pci we still require a driver override to
> > > match the subchannel type; matching more than one subchannel
> > > type is probably not useful anyway.
> > >
> > > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>

Thanks!

>
> I guess the '\n' handling is customary, and is what the same what
> the pci counterpart (782a985d7af2) does anyway. It bothers
> me a little that you don't necessarily get back from with show
> what you stored. E.g. # echo -e "bug\nfree"
> > /sys/bus/css/devices/0.0.0001/driver_override # echo $?
> 0
> # cat /sys/bus/css/devices/0.0.0001/driver_override
> bug
> # echo $?
> 0
> But given the previous art (782a985d7af2) I think it is the best way
> to do it.

Yeah; I shamelessly copied a lot :) And I agree it's probably useful to
have both act in the same way.

>
> The rest is very straightforward.
>
> > > ---
> > >
> > > Lightly tested; did not yet attempt to adapt driverctl to actually
> > > make use of it.
> >
> > Friendly ping.
> >
> > In the meanwhile, I figured out that you do not need to adapt driverctl
> > at all, but just need to pass it '-b css' to work on the css bus; this
> > seems to work just fine with this patch applied.
> >
>
> Interesting. I hope to get around and have a closer look at it
> eventually.

Nice; somebody else looking at it is always useful :)