From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:60478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbfGLLaJ (ORCPT ); Fri, 12 Jul 2019 07:30:09 -0400 Date: Fri, 12 Jul 2019 13:30:06 +0200 From: Cornelia Huck Subject: Re: [PATCH v3 5/5] vfio-ccw: Update documentation for csch/hsch Message-ID: <20190712133006.23efcd0d.cohuck@redhat.com> In-Reply-To: <7d977612c3f3152ffb950d77ae11b4b25c1e20c4.1562854091.git.alifm@linux.ibm.com> References: <7d977612c3f3152ffb950d77ae11b4b25c1e20c4.1562854091.git.alifm@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Farhan Ali Cc: farman@linux.ibm.com, pasic@linux.ibm.com, linux-s390@vger.kernel.org, kvm@vger.kernel.org On Thu, 11 Jul 2019 10:28:55 -0400 Farhan Ali wrote: > We now support CLEAR SUBCHANNEL and HALT SUBCHANNEL > via ccw_cmd_region. > > Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions") > Signed-off-by: Farhan Ali > --- > Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++--- > 1 file changed, 28 insertions(+), 3 deletions(-) (...) > +vfio-ccw cmd region > +------------------- > + > +The vfio-ccw cmd region is used to accept asynchronous instructions > +from userspace. > + Add :: and indent the structure so that we get proper formatting? (Sorry about not noticing this last time; but I can add it while applying if there are no other comments.) > +#define VFIO_CCW_ASYNC_CMD_HSCH (1 << 0) > +#define VFIO_CCW_ASYNC_CMD_CSCH (1 << 1) > +struct ccw_cmd_region { > + __u32 command; > + __u32 ret_code; > +} __packed; > + > +This region is exposed via region type VFIO_REGION_SUBTYPE_CCW_ASYNC_CMD. > + > +Currently, CLEAR SUBCHANNEL and HALT SUBCHANNEL use this region. > + Otherwise, Reviewed-by: Cornelia Huck