From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:51784 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbfIDIbF (ORCPT ); Wed, 4 Sep 2019 04:31:05 -0400 Date: Wed, 4 Sep 2019 10:31:00 +0200 From: Cornelia Huck Subject: Re: [PATCH -next] vfio-ccw: fix error return code in vfio_ccw_sch_init() Message-ID: <20190904103100.4a53d035.cohuck@redhat.com> In-Reply-To: <20190904083315.105600-1-weiyongjun1@huawei.com> References: <20190904083315.105600-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Wei Yongjun Cc: Eric Farman , Halil Pasic , Sebastian Ott , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org, kvm@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, 4 Sep 2019 08:33:15 +0000 Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the memory alloc failed > error handling case instead of 0, as done elsewhere in this function. > > Fixes: 60e05d1cf087 ("vfio-ccw: add some logging") > Signed-off-by: Wei Yongjun > --- > drivers/s390/cio/vfio_ccw_drv.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Ah, yes. Reviewed-by: Cornelia Huck Heiko/Vasily/Christian: can you queue this directly?