From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 18 Sep 2019 19:04:33 +0200 From: Halil Pasic Subject: Re: [PATCH v6 04/10] s390: vfio-ap: filter CRYCB bits for unavailable queue devices In-Reply-To: <1568410018-10833-5-git-send-email-akrowiak@linux.ibm.com> References: <1568410018-10833-1-git-send-email-akrowiak@linux.ibm.com> <1568410018-10833-5-git-send-email-akrowiak@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Message-Id: <20190918190433.713f4a93.pasic@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, mjrosato@linux.ibm.com, pmorel@linux.ibm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, jjherne@linux.ibm.com On Fri, 13 Sep 2019 17:26:52 -0400 Tony Krowiak wrote: > +static void vfio_ap_mdev_get_crycb_matrix(struct ap_matrix_mdev *matrix_mdev) > +{ > + unsigned long apid, apqi; > + unsigned long masksz = BITS_TO_LONGS(AP_DEVICES) * > + sizeof(unsigned long); > + > + memset(matrix_mdev->crycb.apm, 0, masksz); > + memset(matrix_mdev->crycb.apm, 0, masksz); I guess you wanted to zero out aqm here (and not apm again)! > + memcpy(matrix_mdev->crycb.adm, matrix_mdev->matrix.adm, masksz);