From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 7 Oct 2019 16:26:07 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007132607.4q537nauwfn5thol@box> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007130617.GB56546@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: Anshuman Khandual , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > * Anshuman Khandual wrote: > > > This adds a test module which will validate architecture page table helpers > > and accessors regarding compliance with generic MM semantics expectations. > > This will help various architectures in validating changes to the existing > > page table helpers or addition of new ones. > > > > Test page table and memory pages creating it's entries at various level are > > all allocated from system memory with required alignments. If memory pages > > with required size and alignment could not be allocated, then all depending > > individual tests are skipped. > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > index 52e5f5f2240d..b882792a3999 100644 > > --- a/arch/x86/include/asm/pgtable_64_types.h > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > #define pgtable_l5_enabled() 0 > > #endif /* CONFIG_X86_5LEVEL */ > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > + > > extern unsigned int pgdir_shift; > > extern unsigned int ptrs_per_p4d; > > Any deep reason this has to be a macro instead of proper C? It's a way to override the generic mm_p4d_folded(). It can be rewritten as inline function + define. Something like: #define mm_p4d_folded mm_p4d_folded static inline bool mm_p4d_folded(struct mm_struct *mm) { return !pgtable_l5_enabled(); } But I don't see much reason to be more verbose here than needed. -- Kirill A. Shutemov