From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Steffen Maier <maier@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 4/4] vfio-ccw: Rework the io_fctl trace
Date: Wed, 16 Oct 2019 12:17:48 +0200 [thread overview]
Message-ID: <20191016121748.7982cb24.cohuck@redhat.com> (raw)
In-Reply-To: <20191016015822.72425-5-farman@linux.ibm.com>
On Wed, 16 Oct 2019 03:58:22 +0200
Eric Farman <farman@linux.ibm.com> wrote:
> Using __field_struct for the schib is convenient, but it doesn't
> appear to let us filter based on any of the schib elements.
> Specifying, the full schid or any element within it results
s/Specifying,/Specifying/
> in various errors by the parser. So, expand that out to its
> component elements, so we can limit the trace to a single device.
>
> While we are at it, rename this trace to the function name, so we
> remember what is being traced instead of an abstract reference to the
> function control bit of the SCSW.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_fsm.c | 4 ++--
> drivers/s390/cio/vfio_ccw_trace.c | 2 +-
> drivers/s390/cio/vfio_ccw_trace.h | 18 +++++++++++-------
> 3 files changed, 14 insertions(+), 10 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2019-10-16 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 1:58 [PATCH v2 0/4] vfio-ccw: A couple trace changes Eric Farman
2019-10-16 1:58 ` [PATCH v2 1/4] vfio-ccw: Refactor how the traces are built Eric Farman
2019-10-16 10:08 ` Cornelia Huck
2019-10-16 1:58 ` [PATCH v2 2/4] vfio-ccw: Trace the FSM jumptable Eric Farman
2019-10-16 10:10 ` Cornelia Huck
2019-10-16 1:58 ` [PATCH v2 3/4] vfio-ccw: Add a trace for asynchronous requests Eric Farman
2019-10-16 10:15 ` Cornelia Huck
2019-10-16 11:36 ` Eric Farman
2019-10-16 11:39 ` Cornelia Huck
2019-10-16 13:35 ` Eric Farman
2019-10-16 1:58 ` [PATCH v2 4/4] vfio-ccw: Rework the io_fctl trace Eric Farman
2019-10-16 10:17 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016121748.7982cb24.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).