Re: [PATCH v3 0/4] vfio-ccw: A couple trace changes

Cornelia Huck
2019-10-17T10:19:28Z

On Wed, 16 Oct 2019 16:20:36 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> Here a couple updates to the vfio-ccw traces in the kernel,
> based on things I've been using locally. Perhaps they'll
> be useful for future debugging.
>
> v2 -> v3:
> - Added Conny's r-b to patches 1, 2, 4
> - s/command=%d/command=0x%x/ in patch 3 [Cornelia Huck]
>
> v1/RFC -> v2:
> - Convert state/event=%x to %d [Steffen Maier]
> - Use individual fields for cssid/ssid/sch_no, to enable
> filtering by device [Steffen Maier]
> - Add 0x prefix to remaining %x substitution in existing trace
>
> Eric Farman (4):
> vfio-ccw: Refactor how the traces are built
> vfio-ccw: Trace the FSM jumptable
> vfio-ccw: Add a trace for asynchronous requests
> vfio-ccw: Rework the io_fctl trace
>
> drivers/s390/cio/Makefile | 4 +-
> drivers/s390/cio/vfio_ccw_cp.h | 1 +
> drivers/s390/cio/vfio_ccw_fsm.c | 11 +++--
> drivers/s390/cio/vfio_ccw_private.h | 1 +
> drivers/s390/cio/vfio_ccw_trace.c | 14 ++++++
> drivers/s390/cio/vfio_ccw_trace.h | 76 ++++++++++++++++++++++++++---
> 6 files changed, 93 insertions(+), 14 deletions(-)
> create mode 100644 drivers/s390/cio/vfio_ccw_trace.c
>

Thanks, applied.