From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:40926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731515AbfJQKT2 (ORCPT ); Thu, 17 Oct 2019 06:19:28 -0400 Date: Thu, 17 Oct 2019 12:19:24 +0200 From: Cornelia Huck Subject: Re: [PATCH v3 0/4] vfio-ccw: A couple trace changes Message-ID: <20191017121924.3597aa7f.cohuck@redhat.com> In-Reply-To: <20191016142040.14132-1-farman@linux.ibm.com> References: <20191016142040.14132-1-farman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Eric Farman Cc: Halil Pasic , Steffen Maier , Jason Herne , Jared Rossi , linux-s390@vger.kernel.org, kvm@vger.kernel.org On Wed, 16 Oct 2019 16:20:36 +0200 Eric Farman wrote: > Here a couple updates to the vfio-ccw traces in the kernel, > based on things I've been using locally. Perhaps they'll > be useful for future debugging. > > v2 -> v3: > - Added Conny's r-b to patches 1, 2, 4 > - s/command=%d/command=0x%x/ in patch 3 [Cornelia Huck] > > v1/RFC -> v2: > - Convert state/event=%x to %d [Steffen Maier] > - Use individual fields for cssid/ssid/sch_no, to enable > filtering by device [Steffen Maier] > - Add 0x prefix to remaining %x substitution in existing trace > > Eric Farman (4): > vfio-ccw: Refactor how the traces are built > vfio-ccw: Trace the FSM jumptable > vfio-ccw: Add a trace for asynchronous requests > vfio-ccw: Rework the io_fctl trace > > drivers/s390/cio/Makefile | 4 +- > drivers/s390/cio/vfio_ccw_cp.h | 1 + > drivers/s390/cio/vfio_ccw_fsm.c | 11 +++-- > drivers/s390/cio/vfio_ccw_private.h | 1 + > drivers/s390/cio/vfio_ccw_trace.c | 14 ++++++ > drivers/s390/cio/vfio_ccw_trace.h | 76 ++++++++++++++++++++++++++--- > 6 files changed, 93 insertions(+), 14 deletions(-) > create mode 100644 drivers/s390/cio/vfio_ccw_trace.c > Thanks, applied.