Re: [PATCH V9 3/6] mdev: introduce device specific ops

Cornelia Huck
2019-11-06T10:53:08Z

On Wed, 6 Nov 2019 15:05:45 +0800
Jason Wang <jasowang@redhat.com> wrote:

> Currently, except for the create and remove, the rest of
> mdev_parent_ops is designed for vfio-mdev driver only and may not help
> for kernel mdev driver. With the help of class id, this patch
> introduces device specific callbacks inside mdev_device
> structure. This allows different set of callback to be used by
> vfio-mdev and virtio-mdev.
>
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> .../driver-api/vfio-mediated-device.rst | 35 +++++++++----
> MAINTAINERS | 1 +
> drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++---
> drivers/s390/cio/vfio_ccw_ops.c | 18 ++++---
> drivers/s390/crypto/vfio_ap_ops.c | 14 +++--
> drivers/vfio/mdev/mdev_core.c | 24 ++++++++-
> drivers/vfio/mdev/mdev_private.h | 5 ++
> drivers/vfio/mdev/vfio_mdev.c | 37 ++++++-------
> include/linux/mdev.h | 43 ++++-----------
> include/linux/mdev_vfio_ops.h | 52 +++++++++++++++++++
> samples/vfio-mdev/mbochs.c | 20 ++++---
> samples/vfio-mdev/mdpy.c | 20 ++++---
> samples/vfio-mdev/mtty.c | 18 ++++---
> 13 files changed, 206 insertions(+), 99 deletions(-)
> create mode 100644 include/linux/mdev_vfio_ops.h

Reviewed-by: Cornelia Huck <cohuck@redhat.com>