Re: [PATCH 2/5] block: merge invalidate_partitions into rescan_partitions

Christoph Hellwig
2019-11-07T09:55:57Z

On Thu, Nov 07, 2019 at 10:47:39AM +0100, Hannes Reinecke wrote:
> > + check_disk_size_change(disk, bdev, !invalidate);
> > bdev->bd_invalidated = 0;
> >
> > - if (!get_capacity(disk))
> > + if (!get_capacity(disk)) {
> > + /*
> > + * Tell userspace that the media / partition table may have
> > + * changed.
> > + */
> > + kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE);
> > return 0;
> > + }
> >
> I wonder; wouldn't we miss a true size change here?

Why would we? We first unconditionally drop all partitions. Then if
the device ha a non-zero capacity we probe for partitions. What could
we miss?