From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-2.mimecast.com ([205.139.110.61]:32926 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725799AbfLMJd6 (ORCPT ); Fri, 13 Dec 2019 04:33:58 -0500 Date: Fri, 13 Dec 2019 10:33:46 +0100 From: Cornelia Huck Subject: Re: [kvm-unit-tests PATCH v4 7/9] s390x: css: msch, enable test Message-ID: <20191213103346.1e42d52b.cohuck@redhat.com> In-Reply-To: References: <1576079170-7244-1-git-send-email-pmorel@linux.ibm.com> <1576079170-7244-8-git-send-email-pmorel@linux.ibm.com> <20191212130111.0f75fe7f.cohuck@redhat.com> <83d45c31-30c3-36e1-1d68-51b88448f4af@linux.ibm.com> <20191212151002.1c7ca4eb.cohuck@redhat.com> <20191212153303.6444697e.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Pierre Morel Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com On Thu, 12 Dec 2019 18:33:15 +0100 Pierre Morel wrote: > After all, I make it simple by testing if the MSCH works as expected, no > retry, no delay. > This is just a test. That's probably fine if you only run under kvm (not sure what your further plans here are). > > I will add a new patch to add a library function to enable the channel, > with retry to serve when we really need to enable the channel, not to test. A simple enable should be enough for kvm-only usage, we can add a retry easily if needed. We probably can also defer adding the library function until after we get another user :)